Skip to content

reduce usage of expectEqual in behavior tests #24389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

reduce usage of expectEqual in behavior tests #24389

wants to merge 1 commit into from

Conversation

@jeffective
Copy link
Contributor

@jeffective jeffective commented Jul 10, 2025 •
edited
Loading

Does not fully close #24361 (this is only a first, simple change set)

Summary:

  • where the type of the operands allows, change expectEqual(x, y) to expect(x == y) for files in test/behavior/**
# without these changes (master branch)
$ git grep expectEqual test/behavior | wc -l
1028

# with these changes
$ git grep expectEqual test/behavior | wc -l
348

My editor was configured to re-order imports on save. Hope that isn't a huge issue.

Verification evidence:

  • the CI should pass, no new tests are introduced, only changes to existing tests

@jeffective jeffective force-pushed the 24361-reduce-expect-equal-behavior-tests branch from 2611cd9 to 86653d7 Compare July 12, 2025 21:01
@jeffective jeffective marked this pull request as ready for review July 12, 2025 21:30
@jeffective
Copy link
Contributor Author

jeffective commented Jul 13, 2025

requesting review from @alexrp

@jeffective jeffective force-pushed the 24361-reduce-expect-equal-behavior-tests branch from 86653d7 to 4ac97ea Compare July 18, 2025 05:49
@jeffective
Copy link
Contributor Author

jeffective commented Jul 18, 2025

rebased and fixed merge conflict in test/behavior/asm.zig

@jeffective jeffective force-pushed the 24361-reduce-expect-equal-behavior-tests branch 2 times, most recently from c2bf3a2 to 6f5299a Compare August 6, 2025 04:37
@jeffective
Copy link
Contributor Author

jeffective commented Aug 6, 2025

rebased to fix merge conflict

@jeffective jeffective force-pushed the 24361-reduce-expect-equal-behavior-tests branch from 6f5299a to e4fb29c Compare November 3, 2025 00:50
@jeffective jeffective marked this pull request as draft November 3, 2025 01:24
@jeffective
Copy link
Contributor Author

jeffective commented Nov 3, 2025

closing to prevent use of CI until ready

@jeffective jeffective closed this Nov 3, 2025
@jeffective jeffective mentioned this pull request Nov 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewrk andrewrk andrewrk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Behavior tests should avoid expectEqual and friends

2 participants

@jeffective @andrewrk